-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use chromium
instead of a manual chrome download
#178
Conversation
I think we're finally good here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good to me, and I assume this works fine for Chromote? cc @schloerke just to double check.
I think we actually had chromium before and then replaced it with Chrome at some point. The original issue was #86, so I wonder if chromium still has the snap issue.
rules/chrome.json
Outdated
{ | ||
"os": "linux", | ||
"distribution": "ubuntu", | ||
"versions": ["20.04", "22.04"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is Ubuntu 24.04 supported?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Good catch, I lost it in the refactoring as starting with 24.04, the key is chromium
instead of chromium-browser
. Added it.
That was the initial motivation, to get all OS & their archs working for {chromote}. Not sure if #86 is still valid/important as meanwhile one can install it through |
I looks ok to me. I have not tested it. But Thank you for the updates! |
I just tested docker run -it --rm ubuntu:jammy
apt update -qq && apt install -y chromium-browser
$ chromium-browser
Command '/usr/bin/chromium-browser' requires the chromium snap to be installed.
Please install it with:
snap install chromium
$ snap install chromium
error: cannot communicate with server: Post "http://localhost/v2/snaps/chromium": dial unix /run/snapd.socket: connect: no such file or directory So I think we still do have the same issue from #86 where this isn't going to work well for containers. Is there an alternative direct binary download for chromium we could use instead? Just from a quick search, https://www.chromium.org/getting-involved/download-chromium/ lists some script for Linux, but I haven't tested it and it's 8 years old 🤔 |
Ah, now I see what #86 was about. I've found a ppa for jammy/noble: However, it is missing support for NB: please squash-merge to avoid including all the non-meaningful dummy commits in which I fixed the schema. |
Aw, unfortunate that google doesn't provide any nice way of apt installing chromium. We usually avoid 3rd-party PPAs if at all possible, but this one looks fine and doesn't seem like it'll conflict with the default system libraries. Looks good. |
Advantages:
chromium
is available on both amd64 and arm64 for most distros (chrome isn't and e.g. fails on Ubuntu)pre_install
andpost_install
due to direct package manager callNo arch-agnostic solution for the old centos but that shouldn't matter much in practice.
FYI: Currently, {chromote} errors when being installed via pak on any arm64 Linux distribution as the download has amd64 hardcoded.