Carson/feature/plotly crosstalk #281
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- crosstalk::dependencies() was renamed to crosstalk::crosstalkLibs() - Also fix tests and metadata
| @@ -52,5 +52,6 @@ Suggests: | |||
| R6, | |||
| RJSONIO | |||
| Remotes: | |||
| rstudio/crosstalk | |||
| rstudio/crosstalk, | |||
| jcheng5/plotly@joe/feature/crosstalk | |||
| RoxygenNote: 5.0.1 | |||
There was a problem hiding this comment.
This is here just for the time being since we need to access plotly's "global" crosstalk options, as I'm getting here
|
This PR has merge conflicts with master. Is it possible to rebase this PR on the master ? cc @jcheng5 |
Closed
|
Closing in favor of #346 for a cleaner history and better diffing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branches off of
rstudio/leaflet@joe/feature/crosstalk-filter, and adds the ability to coordinate with plotly's logic for dynamic coloring and persistent selections. Here is an example http://rpubs.com/cpsievert/204407