Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Barret Schloerke <[email protected]>
  • Loading branch information
olivroy and schloerke authored Mar 27, 2024
1 parent ad76391 commit 934404c
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 9 deletions.
4 changes: 2 additions & 2 deletions .github/CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Contributing to leaflet
# Contributing to `{leaflet}`

We welcome contributions to the **leaflet** package!
We welcome contributions to the `{leaflet}` package!

To submit a contribution:

Expand Down
3 changes: 2 additions & 1 deletion R/plugin-awesomeMarkers.R
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,8 @@ makeAwesomeIcon <- function(
#' An icon can be represented as a list of the form \code{list(icon, library,
#' ...)}. This function is vectorized over its arguments to create a list of
#' icon data. Shorter argument values will be recycled. \code{NULL} values for
#' these arguments will be ignored. See \url{https://github.com/lennardv2/Leaflet.awesome-markers}
#' these arguments will be ignored.
#' @seealso \url{https://github.com/lennardv2/Leaflet.awesome-markers}
#' @param icon Name of the icon
#' @param library Which icon library. Default \code{"glyphicon"}, other possible
#' values are \code{"fa"} (fontawesome) or \code{"ion"} (ionicons).
Expand Down
3 changes: 1 addition & 2 deletions R/plugin-graticule.R
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,7 @@ leafletGraticuleDependencies <- function() {

#' Add a Graticule on the map
#'
#' See \url{https://github.com/turban/Leaflet.Graticule}
#'
#' @seealso \url{https://github.com/turban/Leaflet.Graticule}
#' @param map a map widget object
#' @param interval The spacing in map units between horizontal and vertical lines.
#' @param sphere boolean. Default `FALSE`
Expand Down
3 changes: 1 addition & 2 deletions R/plugin-minimap.R
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,7 @@ leafletMiniMapDependencies <- function() {

#' Add a minimap to the map
#'
#' See \url{https://github.com/Norkart/Leaflet-MiniMap}
#'
#' @seealso \url{https://github.com/Norkart/Leaflet-MiniMap}
#' @param map a map widget object
#' @param position The standard Leaflet.Control position parameter,
#' used like all the other controls.
Expand Down
3 changes: 1 addition & 2 deletions R/plugin-simplegraticule.R
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,7 @@ leafletSimpleGraticuleDependencies <- function() {

#' Add a simple Graticule on the map
#'
#' See \url{https://github.com/ablakey/Leaflet.SimpleGraticule}
#'
#' @seealso \url{https://github.com/ablakey/Leaflet.SimpleGraticule}
#' @param map a map widget object
#' @param interval The spacing in map units between horizontal and vertical lines.
#' @param showOriginLabel true Whether or not to show '(0,0)' at the origin.
Expand Down

0 comments on commit 934404c

Please sign in to comment.