Improve text_*() error messages
#1774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…)` for better stack trace.
olivroy
force-pushed
the
cols-width-gtable
branch
from
b584a97 to
7298e16
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thought I was done with error messages, but no!
I started this PR as a wish to improve test coverage.
But turns out more work was required to get the
text_*()to have consistent error messages (similar totab_style()andtab_footnote().While working on that, I discovered an error in tidyselect (r-lib/tidyselect#352) It means that some errors will improve naturally when the next tidyselect version will be out.
Test coverage
https://app.codecov.io/gh/rstudio/gt/blob/master/R%2Ftext_transform.R
I also deleted dt_col_merge_init() as it is unused in the codebase. https://app.codecov.io/gh/rstudio/gt/blob/master/R%2Fdt_cols_merge.R
I created the
text_transform_impl()as a way to easily getError intext_case_match()`Coverage data https://app.codecov.io/gh/rstudio/gt/pull/1774