-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding repo owner input #2774
Adding repo owner input #2774
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job, the fix are simple and straight to the point. Well done!
I just have a few comments just to keep the solution following same principles to deal with the situations when to run or not the pipeline or when we are configuring and using github variables.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
716b824
to
0f7e380
Compare
1a8fb16
to
0f7e380
Compare
3d92a19
to
9f433cf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Good Job!
Quality Gate passedIssues Measures |
Description
Right now, checks for pull requests (PRs) from external contributors using forked repositories are not passing. The main issue is that the rootstock-integration-tests workflow is attempting to find the branch in the original rsksmart/rskj repository instead of the contributor's fork. Here are the specific problems we've encountered:
Git Checkout Error: error: pathspec 'vovchyk/status-badge' did not match any file(s) known to git
and
It appears that the SonarQube check is being triggered automatically for external PRs of branches from forked repos, which should not happen due to potential access issues
Implementation
Updated
rit.yml
Workflow:Added the repo-owner input to the Rootstock Integration Tests action to ensure it correctly clones the repository based on the PR's owner:
Conditionally Trigger SonarQube Check:
Implemented logic to skip the SonarQube check for PRs from external contributors. This prevents unnecessary execution that could fail due to access issues.
if [ "$GH_EVENT" = pull_request ] && [ "${{ github.event.pull_request.head.repo.fork }}" != "true" ]; then
How Has This Been Tested?
I created two branches in my forked repositories for
rskj
androotstock-integration-tests
to test my changes. I verified that everything works correctly in the forked repos. Here are the pull requests:Types of changes
Checklist: