Certificate V2 sgx_quote type element validation #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- HSMCertificateV2Element base class now raises not implemented errors for is_valid and get_pubkey - Implemented is_valid in HSMCertificateV2ElementSGXQuote - HSMCertificateV2ElementSGXQuote's message method now returns an SgxQuote - Mocking is_valid and get_pubkey in the rest of HSMCertificateV2Element's subclasses - Added and updated unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HSMCertificateV2Elementbase class now raises not implemented errors foris_validandget_pubkeyis_validinHSMCertificateV2ElementSGXQuoteHSMCertificateV2ElementSGXQuote'smessagemethod now returns anSgxQuoteis_validandget_pubkeyin the rest ofHSMCertificateV2Element's subclasses