Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Certificate V2 parser #230

Merged

Conversation

amendelzon
Copy link
Collaborator

  • Added version mapping and parsing logic to certificate version 1
  • Added dict based initialisation functions to HSMCertificateV2Element and its subclasses
  • Updated sgx attestation gathering certificate generation
  • Added and updated unit tests
  • Ignoring long line linting in certificate v2 resources file

- Added version mapping and parsing logic to certificate version 1
- Added dict based initialisation functions to HSMCertificateV2Element and its subclasses
- Updated sgx attestation gathering certificate generation
- Added and updated unit tests
- Ignoring long line linting in certificate v2 resources file
italo-sampaio
italo-sampaio previously approved these changes Dec 18, 2024
Copy link
Collaborator

@italo-sampaio italo-sampaio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Added a few comments inline with a minor suggestion

middleware/admin/certificate_v1.py Outdated Show resolved Hide resolved
middleware/admin/certificate_v1.py Show resolved Hide resolved
Copy link
Collaborator

@italo-sampaio italo-sampaio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amendelzon amendelzon merged commit 76b4683 into feature/sgx-attestation Dec 18, 2024
5 checks passed
@amendelzon amendelzon deleted the enhancement/sgx-attestation-cert-v2-parser branch December 18, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants