Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Certificate V2 generator #229

Conversation

amendelzon
Copy link
Collaborator

  • Added individual certificate v2 element types with serialization logic: SgxQuote, SgxAttestationKey and X509
  • Added CStruct abstraction to simplify representing C structs
  • Added struct definitions as CStruct subtypes based on OpenEnclave's endorsement type definitions
  • Updated SGX attestation gathering logic to parse the envelope and generate the actual certificate elements
  • Added and updated unit tests
  • Ignoring long line linting in envelope unit tests

- Added individual certificate v2 element types with serialization logic: SgxQuote, SgxAttestationKey and X509
- Added CStruct abstraction to simplify representing C structs
- Added struct definitions as CStruct subtypes based on OpenEnclave's endorsement type definitions
- Updated SGX attestation gathering logic to parse the envelope and generate the actual certificate elements
- Added and updated unit tests
- Ignoring long line linting in envelope unit tests
Copy link
Collaborator

@italo-sampaio italo-sampaio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@amendelzon amendelzon merged commit 5c53967 into feature/sgx-attestation Dec 16, 2024
5 checks passed
@amendelzon amendelzon deleted the enhancement/sgx-attestation-cert-v2-generator branch December 16, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants