Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SGX attestation gathering #228

Merged

Conversation

amendelzon
Copy link
Collaborator

  • Unified certificates in certificate module
  • Moved existing HSMCertificate and HSMCertificateElement to certificate_v1
  • Added new HSMCertificateV2 and HSMCertificateV2Element (and subclasses)
  • Added new attestation gathering operation for adm_sgx
  • Added new attestation gathering module used within adm_sgx
  • Factored out user-defined value gathering into admin/misc module
  • Current SGX attestation saving to file is directly translated from value grabbed with HSM2Dongle
  • Added and updated unit tests

- Unified certificates in certificate module
- Moved existing HSMCertificate and HSMCertificateElement to certificate_v1
- Added new HSMCertificateV2 and HSMCertificateV2Element (and subclasses)
- Added new attestation gathering operation for adm_sgx
- Added new attestation gathering module used within adm_sgx
- Factored out user-defined value gathering into admin/misc module
- Current SGX attestation saving to file is directly translated from value grabbed with HSM2Dongle
- Added and updated unit tests
Copy link
Collaborator

@italo-sampaio italo-sampaio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Left a comment regarding the relationship between certificate_v1 / certificate_v2, but take that more as a question than a suggestion.

middleware/admin/certificate_v1.py Show resolved Hide resolved
@amendelzon amendelzon merged commit 0663ff7 into feature/sgx-attestation Dec 6, 2024
5 checks passed
@amendelzon amendelzon deleted the enhancement/sgx-attestation-gathering branch December 6, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants