Added unit tests for the nvmem module #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amendelzon
reviewed
Oct 1, 2024
amendelzon
reviewed
Oct 1, 2024
amendelzon
reviewed
Oct 1, 2024
amendelzon
reviewed
Oct 1, 2024
amendelzon
reviewed
Oct 1, 2024
sest_read returns a uint8_t size, which is compared with nvm_block_t.size whenever nvm_load is called. Allowing the caller to register a block with a size over the maximum uint8_t size could lead to an inconsistency when nvm_load is used. This commit changes the block size to uint8_t to make it consistent.
- reverted block size type back to size_t - moved all mocks to the `mock` dir - reworked Makefile to get rid of uneeded targets - added all warnings to common.mk
italo-sampaio
force-pushed
the
enhancement/nvmem-unit-tests
branch
from
f4f66d2 to
b9ae604
Compare
amendelzon
pushed a commit
that referenced
this pull request
Oct 22, 2024
* Added unit tests for SGX HAL nvmem module * Added SGX HAL unit tests to the CI * Added check to avoid for buffer overrun on nvmem.c
amendelzon
pushed a commit
that referenced
this pull request
Oct 22, 2024
* Added unit tests for SGX HAL nvmem module * Added SGX HAL unit tests to the CI * Added check to avoid for buffer overrun on nvmem.c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hal/sgx/src/trusted/nvmem.c