Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAO-471: New Instance for DAO #146

Merged
merged 1 commit into from
Jun 28, 2024
Merged

DAO-471: New Instance for DAO #146

merged 1 commit into from
Jun 28, 2024

Conversation

sleyter93
Copy link
Collaborator

@sleyter93 sleyter93 commented Jun 25, 2024 •
edited
Loading

Based on the PROFILE env variable, we will load different .env files.
There are two env files, one for wallet and another for dao.
To get running this, you can execute the following command:
PROFILE=dao npm run start
Default profile is wallet

@sleyter93 sleyter93 self-assigned this Jun 25, 2024
@sleyter93 sleyter93 changed the title DAO-471: Profiles DAO-471: New Instance for DAO Jun 25, 2024
@sleyter93 sleyter93 marked this pull request as ready for review June 25, 2024 17:32
jessgusclark
jessgusclark reviewed Jun 26, 2024
View reviewed changes
Copy link
Member

@jessgusclark jessgusclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the wallet is the default, I assume if we merge this the wallet deployment (that already exists) will deploy as normal?

@sleyter93 sleyter93 requested a review from jessgusclark June 27, 2024 04:40
@sleyter93
Copy link
Collaborator Author

sleyter93 commented Jun 27, 2024 •
edited
Loading

Since the wallet is the default, I assume if we merge this the wallet deployment (that already exists) will deploy as normal?

To deploy with the current cd.yml, I updated the Dockerfile. Now, we can deploy it as always.

Freshenext
Freshenext approved these changes Jun 28, 2024
View reviewed changes
Copy link
Collaborator

@Freshenext Freshenext left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go!

@Freshenext Freshenext merged commit 359108f into develop Jun 28, 2024
1 check passed
@Freshenext Freshenext deleted the DAO-471 branch June 28, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Freshenext Freshenext Freshenext approved these changes

@jessgusclark jessgusclark Awaiting requested review from jessgusclark

Assignees

@sleyter93 sleyter93

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sleyter93 @jessgusclark @Freshenext