Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

estimation-no-signature #158

Merged
merged 7 commits into from
Sep 2, 2024
Merged

estimation-no-signature #158

merged 7 commits into from
Sep 2, 2024

Conversation

franciscotobar
Copy link
Collaborator

@franciscotobar franciscotobar commented Sep 1, 2024 •
edited
Loading

What

  • Estimation without signature

Why

  • UX improvement to not require additional signed tx

Refs

@franciscotobar franciscotobar changed the title Estimation no signature estimation-no-signature Sep 1, 2024
@franciscotobar franciscotobar marked this pull request as ready for review September 1, 2024 23:44
@franciscotobar franciscotobar force-pushed the estimation-no-signature branch from f720cec to 84b7390 Compare September 2, 2024 03:27
@franciscotobar franciscotobar force-pushed the estimation-no-signature branch from 84b7390 to 7f5321b Compare September 2, 2024 04:07
@franciscotobar franciscotobar mentioned this pull request Sep 2, 2024
Merged
antomor
antomor reviewed Sep 2, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
antomor
antomor approved these changes Sep 2, 2024
View reviewed changes
Copy link
Collaborator

@antomor antomor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antomor antomor merged commit 723893c into main Sep 2, 2024
3 checks passed
@antomor antomor deleted the estimation-no-signature branch September 2, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antomor antomor antomor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@franciscotobar @antomor