PP-885/explore-solution-b2 #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franciscotobar
force-pushed
the
PP-885/explore-solution-b2
branch
from
52f1fca to
6be340e
Compare
antomor
approved these changes
Jan 31, 2024
franciscotobar
force-pushed
the
PP-885/explore-solution-b2
branch
5 times, most recently
from
bb4bd1e to
483389a
Compare
franciscotobar
commented
Feb 8, 2024
franciscotobar
force-pushed
the
PP-885/explore-solution-b2
branch
3 times, most recently
from
317e6c1 to
e6760c1
Compare
raullaprida
reviewed
Feb 13, 2024
There was a problem hiding this comment.
I have a question regarding the allowed destinations. This being always on might not have the desired outcome in regular relay servers, as they would have to whitelist every single possible destination. Assuming this is being pushed on the main branch, shouln't we add a configuration option to enable this whitelist and having it disabled by default?
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
franciscotobar
force-pushed
the
PP-885/explore-solution-b2
branch
2 times, most recently
from
ff5430a to
a1ae292
Compare
antomor
reviewed
Feb 15, 2024
| return await handler.getAcceptedContracts(); | ||
| } catch (error) { | ||
| log.warn( | ||
| `Couldn't get accepted contracts from verifier ${verifier}`, |
Check warning
Code scanning / CodeQL
Log injection Medium
|
|
||
| return await handler.getAcceptedTokens(); | ||
| } catch (error) { | ||
| log.warn(`Couldn't get accepted tokens from verifier ${verifier}`, error); |
Check warning
Code scanning / CodeQL
Log injection Medium
antomor
force-pushed
the
PP-885/explore-solution-b2
branch
from
aaca9a2 to
cb4f8be
Compare
* ci: add boltz configuration * ci: update deployment script to be used * ci: update server version * docs: fix swagger api
raullaprida
reviewed
Feb 23, 2024
raullaprida
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Why
Refs