Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix/resend-transaction #130

Merged
merged 3 commits into from
Oct 3, 2023
Merged

fix/resend-transaction #130

merged 3 commits into from
Oct 3, 2023

Conversation

franciscotobar
Copy link
Collaborator

What

  • fix parsing txToSing prior resending it
  • fix await all PromiseOrValue instead of parsing to String

Why

  • Ethers does not accept variables that are not part of the object
  • Avoid miss-expected bevaviors

@franciscotobar
Copy link
Collaborator Author

I added an extra commit that we may ignore if are too much changes.

github-advanced-security[bot]
github-advanced-security bot found potential problems Sep 29, 2023
View reviewed changes
src/relayServerUtils.ts Fixed Show fixed Hide fixed
src/relayServerUtils.ts Fixed Show fixed Hide fixed
antomor
antomor approved these changes Sep 29, 2023
View reviewed changes
Copy link
Collaborator

@antomor antomor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@franciscotobar LGTM!
Have you also tried to run the integration tests against this version? Are we sure that these change didn't break them?

@antomor
Copy link
Collaborator

antomor commented Sep 29, 2023 •
edited
Loading

I added an extra commit that we may ignore if are too much changes.

No, they're fine 👍🏼

@franciscotobar
Copy link
Collaborator Author

@franciscotobar LGTM! Have you also tried to run the integration tests against this version? Are we sure that these change didn't break them?

No, Ill run it against it and will do the necessary changes.

@antomor antomor merged commit 945c09c into main Oct 3, 2023
3 checks passed
@antomor antomor deleted the fix/resendTransaction branch October 3, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antomor antomor antomor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@franciscotobar @antomor