Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PP-841: retrieve server version from package.json #127

Merged
merged 2 commits into from
Sep 26, 2023
Merged

PP-841: retrieve server version from package.json #127

merged 2 commits into from
Sep 26, 2023

Conversation

antomor
Copy link
Collaborator

@antomor antomor commented Sep 21, 2023

What

  • retrieve server version from package.json

Why

  • it's hard-coded

@antomor antomor self-assigned this Sep 21, 2023
@antomor antomor requested a review from a team September 21, 2023 13:32
@antomor antomor marked this pull request as ready for review September 21, 2023 13:40
franciscotobar
franciscotobar approved these changes Sep 22, 2023
View reviewed changes
Copy link
Collaborator

@franciscotobar franciscotobar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antomor antomor force-pushed the PP-841/fix-server-version branch from 1c07d0c to ae3113c Compare September 22, 2023 14:34
@antomor antomor force-pushed the PP-841/fix-server-version branch from ae3113c to aadcd36 Compare September 26, 2023 08:31
@antomor antomor merged commit e17c59e into main Sep 26, 2023
3 checks passed
@antomor antomor deleted the PP-841/fix-server-version branch September 26, 2023 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franciscotobar franciscotobar franciscotobar approved these changes

Assignees

@antomor antomor

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antomor @franciscotobar