Skip to content
This repository has been archived by the owner on Nov 7, 2023. It is now read-only.

PP 137: Unnecessary domain separator #21

Merged
merged 5 commits into from
Jun 28, 2022
Merged

PP 137: Unnecessary domain separator #21

merged 5 commits into from
Jun 28, 2022

Conversation

antomor
Copy link
Collaborator

@antomor antomor commented Jun 28, 2022

What

  • Modify some types and functions in order to avoid passing the domain separator as part of the request and also as function parameters.

Why

  • This extra and unnecessary field makes the operation more expensive.

Refs

@antomor antomor changed the title Pp 137/unnecessary domain separator PP 137: Unnecessary domain separator Jun 28, 2022
@antomor antomor mentioned this pull request Jun 28, 2022
Closed
@lgtm-com
Copy link
Contributor

lgtm-com bot commented Jun 28, 2022

This pull request fixes 1 alert when merging a0e7286 into 1e4f5ba - view on LGTM.com

fixed alerts:

  • 1 for Polynomial regular expression used on uncontrolled data

@antomor antomor merged commit a160de8 into master Jun 28, 2022
@antomor antomor deleted the PP-137/unnecessary-domain-separator branch June 28, 2022 19:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AndresQuijano AndresQuijano AndresQuijano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antomor @AndresQuijano