Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: nonce from worker signer #97

Merged
merged 3 commits into from
Sep 9, 2024
Merged

fix: nonce from worker signer #97

merged 3 commits into from
Sep 9, 2024

Conversation

franciscotobar
Copy link
Collaborator

@franciscotobar franciscotobar commented Sep 5, 2024 •
edited
Loading

What

  • Additional gas cost for touched accounts or storage

Why

  • After the owner already interacted with RIF Relay there are some storage that are touched, this storage needs cost to be subtracted from the request

@franciscotobar franciscotobar force-pushed the estimation-no-signature-2 branch 2 times, most recently from 29db56b to ccc86fd Compare September 5, 2024 17:52
@franciscotobar franciscotobar force-pushed the estimation-no-signature-2 branch from ccc86fd to facacd7 Compare September 6, 2024 00:14
@franciscotobar franciscotobar marked this pull request as ready for review September 6, 2024 00:17
@franciscotobar franciscotobar mentioned this pull request Sep 6, 2024
Merged
antomor
antomor reviewed Sep 9, 2024
View reviewed changes
src/gasEstimator/utils.ts Outdated Show resolved Hide resolved
antomor
antomor approved these changes Sep 9, 2024
View reviewed changes
Copy link
Collaborator

@antomor antomor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@franciscotobar franciscotobar merged commit 48dd6c8 into main Sep 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antomor antomor antomor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@franciscotobar @antomor