Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for eth_blockNumber #27

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add support for eth_blockNumber #27

wants to merge 1 commit into from

Conversation

alexkeating
Copy link

Description

  • I added support for eth_blockNumber based on Support eth_blockNumber #26. A bunch of formatting changes were made as well let me know if you want those removed.

jessgusclark
jessgusclark requested changes Oct 17, 2022
View reviewed changes
Copy link
Member

@jessgusclark jessgusclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for the contribution! I love the suggestion and would be happy to include it. However, you are using custom linting rules that changed a lot of code as a result. Please use the repo's existing lint rules.

jessgusclark
jessgusclark requested changes Oct 17, 2022
View reviewed changes
src/index.ts
Comment on lines +31 to +32
const BLOCK_TIME = 14000; // assume 14 second blocktime
const GENISIS_BLOCK = 1539556481000; // Sun Oct 14 2018 22:34:41 GMT+0000
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should be customizable in the constructor and not hardcoded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessgusclark jessgusclark jessgusclark requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexkeating @jessgusclark