Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardhat migration - Deployment scripts #283

Open
wants to merge 6 commits into
base: hardhat-migration
Choose a base branch
from

Conversation

Luisfc68
Copy link
Collaborator

@Luisfc68 Luisfc68 commented Dec 13, 2024

What

  • Add hardhat and typescript to the project
  • Add hardhat project structure
  • Remove truffle dependencies
  • Refactor deployment files to use typescript
  • Add eslint and prettier
  • Add test to validate the deployment scripts
  • Document existing deployment scripts

Why

We're migrating to hardhat because truffle suite is being deprecated which becomes a blocker to continue with important activities such as ownership migration to a multisig and contract split to avoid the size limit. This is a blocker because doing this activities with a deprecated tool suite is insecure and error prone.

Task

https://rsklabs.atlassian.net/browse/GBI-2371

Disclaimer

All the SonarCloud findings were in legacy tests files, this will be removed at the end of the migration.

Copy link

github-actions bot commented Dec 13, 2024

Dependency Review

The following issues were found:

  • ✅ 0 vulnerable package(s)
  • ✅ 0 package(s) with incompatible licenses
  • ✅ 0 package(s) with invalid SPDX license definitions
  • ✅ 0 package(s) with unknown licenses.
  • ⚠️ 30 packages with OpenSSF Scorecard issues.

View full job summary

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
7 New Blocker Issues (required ≤ 0)
3 New Critical Issues (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@Luisfc68 Luisfc68 marked this pull request as ready for review December 13, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants