allow more time formats to prettylog command #699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank You!
First, I want to express my gratitude to the authors of the zerolog library—it’s an amazing tool that I truly appreciate!
Summary
This PR extends the functionality of the prettylog command by enabling the use of a wider range of supported time formats. The current limitation to Kitchen and RFC1123 formats can be restrictive in certain scenarios, as I’ve experienced.
Proposed Changes
Include the following additional time formats:
Allow users to specify their own custom Go time format strings, offering maximum flexibility.
Retain the existing
defaultandfullformats to ensure seamless upgrades for current users.This update expands the functionality of prettylog while respecting the existing defaults, ensuring a smooth transition for current users. I believe this enhancement will benefit a wide range of use cases and make the tool even more versatile.