Merge pull request #212 from rrze-mmz/208-error-on-generating-smil-fi…

…les-command Add title validation rule
rrze-mmz · Jan 17, 2025 · 655b913 · 655b913
2 parents 140cb2e + f10ceb3
commit 655b913
Show file tree

Hide file tree

Showing 6 changed files with 24 additions and 32 deletions.
diff --git a/app/Http/Requests/StoreClipRequest.php b/app/Http/Requests/StoreClipRequest.php
@@ -24,7 +24,7 @@ public function authorize(): bool
     public function rules(): array
     {
         return [
-            'title' => ['required'],
+            'title' => ['required', 'string', 'max:255'],
             'description' => ['string', 'nullable'],
             'recording_date' => ['required', 'date'],
             'organization_id' => ['required', 'integer'],

diff --git a/app/Http/Requests/StoreCollectionRequest.php b/app/Http/Requests/StoreCollectionRequest.php
@@ -6,13 +6,6 @@
 
 class StoreCollectionRequest extends FormRequest
 {
-    protected function prepareForValidation()
-    {
-        $this->merge([
-            'is_public' => $this->is_public === 'on',
-        ]);
-    }
-
     /**
      * Determine if the user is authorized to make this request.
      *
@@ -32,9 +25,16 @@ public function rules()
     {
         return [
             'position' => ['required', 'integer'],
-            'title' => ['required', 'string'],
+            'title' => ['required', 'string', 'max:255'],
             'description' => ['nullable', 'max:1000'],
             'is_public' => ['required', 'boolean'],
         ];
     }
+
+    protected function prepareForValidation()
+    {
+        $this->merge([
+            'is_public' => $this->is_public === 'on',
+        ]);
+    }
 }
diff --git a/app/Http/Requests/StoreDeviceRequest.php b/app/Http/Requests/StoreDeviceRequest.php
@@ -6,30 +6,11 @@
 
 class StoreDeviceRequest extends FormRequest
 {
-    protected function prepareForValidation()
-    {
-        $this->merge([
-            'has_recording_func' => $this->has_recording_func === 'on',
-            'has_livestream_func' => $this->has_livestream_func === 'on',
-            'is_hybrid' => $this->is_hybrid === 'on',
-            'operational' => $this->operational === 'on',
-
-        ]);
-    }
-
-    /**
-     * Determine if the user is authorized to make this request.
-     *
-     * @return bool
-     */
-    public function authorize()
+    public function authorize(): bool
     {
         return auth()->user()->isAdmin() || auth()->user()->isAssistant();
     }
 
-    /**
-     * Get the validation rules that apply to the request.
-     */
     public function rules(): array
     {
         return [
@@ -51,4 +32,15 @@ public function rules(): array
             'telephone_number' => ['digits_between:5,12', 'nullable'],
         ];
     }
+
+    protected function prepareForValidation(): void
+    {
+        $this->merge([
+            'has_recording_func' => $this->has_recording_func === 'on',
+            'has_livestream_func' => $this->has_livestream_func === 'on',
+            'is_hybrid' => $this->is_hybrid === 'on',
+            'operational' => $this->operational === 'on',
+
+        ]);
+    }
 }
diff --git a/app/Http/Requests/StoreSeriesRequest.php b/app/Http/Requests/StoreSeriesRequest.php
@@ -25,7 +25,7 @@ public function authorize(): bool
     public function rules()
     {
         return [
-            'title' => ['required'],
+            'title' => ['required', 'string', 'max:255'],
             'description' => ['string', 'nullable'],
             'organization_id' => ['required', 'integer'],
             'presenters' => ['array'],

diff --git a/app/Http/Requests/UpdateClipRequest.php b/app/Http/Requests/UpdateClipRequest.php
@@ -25,7 +25,7 @@ public function rules(): array
     {
 
         return [
-            'title' => ['required'],
+            'title' => ['required', 'string', 'max:255'],
             'description' => ['string', 'nullable'],
             'recording_date' => ['required', 'date'],
             'organization_id' => ['required', 'integer'],

diff --git a/app/Http/Requests/UpdateSeriesRequest.php b/app/Http/Requests/UpdateSeriesRequest.php
@@ -25,7 +25,7 @@ public function authorize(): bool
     public function rules()
     {
         return [
-            'title' => ['required'],
+            'title' => ['required', 'string', 'max:255'],
             'description' => ['string', 'nullable'],
             'organization_id' => ['required ', 'integer'],
             'slug' => ['required'],