Fix spec bconds and cmake options #325
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does libsolv provide a pkg-config file? If it does, then you should use "pkgconfig --static --libs libsolv" way instead of hard-coding libsolv dependencies into DNF5. Also dnf5.spec should build-require libsolv-static instead of repeating transitive dependencies of libsolv. |
kontura
reviewed
Apr 4, 2023
| @@ -29,7 +29,7 @@ set(SWIG_COMPILE_OPTIONS | |||
| -Wno-missing-declarations | |||
| -Wno-missing-field-initializers | |||
| -Wno-sign-compare | |||
| -Wno-sometimes-uninitialized | |||
| # -Wno-sometimes-uninitialized | |||
There was a problem hiding this comment.
This should be no longer needed, the problem was fixed in glib.
|
@dmach There is unanswered question from ppisar. May I ask you for your plans with the PR? |
|
rebased here to test #876 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's also a test running in GitHub Actions, but it takes over 40 minutes.
It's started only on changes in CMakeLists.txt and spec.
I'm not sure whether to keep it on by default.