-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port UART updates to rp235x-hal #841
Conversation
What testing has been done? Should I run a demo and try it? |
Only tested that it still builds. It seems like we don't have on-target tests for UART yet. |
I think we should write a loop back test that sends bytes with good and bad parity, just to check this is working as expected. |
I wrote a UART loopback program, and fixed some issues I observed: 1f6251a You can cherry-pick that here if you like it. |
Whilst testing it I fixed some UART driver bugs I found. I also re-synchronised RP235x and RP2040 UART drivers.
Thanks! |
No I didn't. Just a DuPont wire on a Pimoroni Pico 2 Plus. |
Interesting. I reproducibly got a break error on rp2040 before I activated the pull-ups. |
🤷 |
The updates from #798, #837 and #838 were only applied to rp2040-hal. This patch ports them to rp235x-hal.