Extend tests in gpio::check_pin_groups()
#817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced the uses of `assert!(x == y)` with `assert_eq!()`, so it was more clear which pin was wrong when tests failed. Also added checks for `group.set(...)`, `group.set_u32(...)`, on top of the existing `group.toggle()` Switch hex numbers to binary to make it easier to read the bits Signed-off-by: hfly0 <[email protected]>
|
@hfly0 would you mind runnning |
Oops, I remembered to run the tests, but didn't remember to format the code. Should be fixed now! |
thejpster
approved these changes
Jul 21, 2024
ithinuel
approved these changes
Jul 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was scrolling through the code and I thought I could fix this while I was at it. I just extended the tests in
gpio.rsa tiny bit.Changes
Replaced the uses of
assert!(x == y)withassert_eq!(), so it was more clear which pin was wrong when tests failed.Also added checks for
group.set(...),group.set_u32(...), on top of the existinggroup.toggle()Switch hex numbers to binary to make it easier to read the bits.