Allow free-running ADC mode without FIFO #739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jannic
force-pushed
the
adc-fifo
branch
5 times, most recently
from
9a88d2f to
66e93e5
Compare
This was
linked to
issues
Jan 3, 2024
jannic
added
enhancement
9names
approved these changes
Feb 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AdcFifoBuilder::prepare(self)toAdcFifoBuilder::start_paused(self)as it more clearly describes what it does.AdcChannel, implemented byAdcPinandTempSense. Main difference to embedded hal'sChanneltype:AdcChannel::channel(&self)has the&selfparameter, so it can be sanely implemented forDynPin.Adc::free_running(&mut self, pin: &dyn AdcChannel)to configure free-running mode on an ADCAdc::wait_ready(&self)andAdc::is_ready(&self)mainly for completeness (not sure if they are useful?)AdcFifo::trigger(&mut self)to be able to useAdcFifowithout free-running modeAdcFifo::is_ready(&self)