Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement InputPin for all pin configurations via .as_input() function #694

Merged
merged 3 commits into from
Sep 28, 2023

Conversation

jannic
Copy link
Member

@jannic jannic commented Sep 20, 2023

Closes #689

@jannic jannic changed the title Implement InputPin for all pin configurations Implement InputPin for all pin configurations via .as_input() function Sep 20, 2023
Copy link
Member

@9names 9names left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, except for the docs on the as_input pin.
See comments for details.

rp2040-hal/src/gpio/mod.rs Outdated Show resolved Hide resolved
Co-authored-by: 9names <[email protected]>
@jannic jannic merged commit d70164c into rp-rs:main Sep 28, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow reading the input state of pins in any function mode
2 participants