Merge pull request #714 from jannic/comment-shift-direction

Document default value for ShiftDirection
rp-rs · Nov 10, 2023 · 757a0b0 · 757a0b0
2 parents 0046f4d + 93b7106
commit 757a0b0
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/rp2040-hal/src/pio.rs b/rp2040-hal/src/pio.rs
@@ -1933,6 +1933,10 @@ pub enum InstallError {
 impl<P: PIOExt> PIOBuilder<P> {
     /// Set config settings based on information from the given [`pio::Program`].
     /// Additional configuration may be needed in addition to this.
+    ///
+    /// Note: The shift direction for both input and output shift registers
+    /// defaults to `ShiftDirection::Left`, which is different from the
+    /// rp2040 reset value.
     pub fn from_program(p: InstalledProgram<P>) -> Self {
         PIOBuilder {
             clock_divisor: (1, 0),