Fix encoding of IN instruction with bit_count == 32 w/ tests #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks to @xeniarose for finding and reporting this bug Fixes rp-rs#57
|
I did try to add a panic on bit_count == 0, but it breaks existing tests. |
That actually pointed to another bug in the handling of bit_count: The instruction decoder took a value of 0 literally, instead of interpreting it as 32. |
|
Thanks, glad you worked it out (I'll have to read your fix). I'll close this PR since you've got it covered |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #58
Fixes #57