forked from firecracker-microvm/firecracker
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): Bump toml_edit from 0.20.0 to 0.20.2 #52
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an option to pytest to run our integration test suite for an arbitrary firecracker binary, instead of compiling it from source. Signed-off-by: Patrick Roy <[email protected]> Co-authored-by: Pablo Barbáchano <[email protected]>
Instead pass the path to the temporary checkout to the test_runner closure. The reason being that by automatically chdir-ing into the temporary directory, it is difficult for the test_runner to get access to things outside of the temp dir (which has to be explicitly passed via closure). Without, the test runner knows both where the permanent firecracker checkout is (via Path.cwd()), and can easily chdir to the temporary one via the ab_test.chdir() context manager. Signed-off-by: Patrick Roy <[email protected]>
Added scipy (for statistical tests) and ipython. We pin numpy to version 1.24.2, as versions newer than this cause python to crash with SIGILL on AL2 4.14 c7g.metal instances. I expect this will be patched in the upcoming 1.25.3 release. See numpy/numpy#24028 Also drop boto3, which is unneccessary since d1015be. Signed-off-by: Patrick Roy <[email protected]> Co-authored-by: Pablo Barbáchano <[email protected]>
We add a version of the nightly snapshot restore test that does not interface with the current baseline-based testing framework. Instead, it will only write the latency samples to test_results. It respects the --binary-dir option, meaning this test can be used to collect latency samples for firecracker binaries compiled from old revisions. We choose this approach of doing a "data production only" test, instead of having the actual A/B-test be done inside of pytest for multiple reasons: - We cannot compile old firecracker versions from inside pytest, as this would require us to nest docker (or rely on the old firecracker revision being compilable with the current docker container). - Doing the A/B-orchestration outside of the test means the test does not need to support "metrics only" and "A/B" modes (with the former being required for nightly data collection runs). Signed-off-by: Patrick Roy <[email protected]>
This script is intended to be executed by our CI to perform an A/B-test across two commits (for instance, a buildkite pipeline would get triggered on PR merge, and the pipeline will call this script with the commit range of the just merged PR). It compiles two git revisions of firecracker using the revisions devtool, and then passes these binaries to the relevant A/B-test. After collecting data for both A and B revision, it analyzes the produced EMF logs for raw time series (e.g. EMF properties/metrics that are assigned lists of values). For any such data series found, it will then perform a statistical test to assert that there is no regression in this data series (for this, it asserts that both A and B revision produce the same EMF messages (based on dimensions), and that for each unique dimension, the same data series are emitted). We choose a Permutation Test as it is non-parametric (which we need since we cannot make normality assumptions about arbitrary performance data). Non-parametric here means it compares two arbitrary sets of samples, and then gives us a p-value about the H_0 hypothesis "both sets of samples were drawn from the same (unknown) distribution". The p-value is easy to interpret, as it tells us the probability of observing a result as bad as the actually measured one, given that performance did not change. Signed-off-by: Patrick Roy <[email protected]>
Signed-off-by: Patrick Roy <[email protected]>
Signed-off-by: Patrick Roy <[email protected]>
Signed-off-by: Patrick Roy <[email protected]>
Signed-off-by: Patrick Roy <[email protected]>
Signed-off-by: Patrick Roy <[email protected]>
Signed-off-by: Patrick Roy <[email protected]>
Signed-off-by: Patrick Roy <[email protected]>
Signed-off-by: Patrick Roy <[email protected]>
Signed-off-by: Patrick Roy <[email protected]>
Signed-off-by: Patrick Roy <[email protected]>
Signed-off-by: Patrick Roy <[email protected]>
Signed-off-by: Patrick Roy <[email protected]>
Signed-off-by: Patrick Roy <[email protected]>
Signed-off-by: Patrick Roy <[email protected]>
Signed-off-by: Patrick Roy <[email protected]>
Signed-off-by: Patrick Roy <[email protected]>
Signed-off-by: Patrick Roy <[email protected]>
Signed-off-by: Patrick Roy <[email protected]>
Bumps [toml_edit](https://github.com/toml-rs/toml) from 0.20.0 to 0.20.2. - [Commits](toml-rs/toml@v0.20.0...v0.20.2) --- updated-dependencies: - dependency-name: toml_edit dependency-type: indirect update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
added
dependencies
Pull requests that update a dependency file
rust
Pull requests that update Rust code
labels
Oct 9, 2023
Looks like toml_edit is no longer updatable, so this is no longer needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps toml_edit from 0.20.0 to 0.20.2.
Commits
ed597eb
chore: Release257a0fd
docs: Update changelog4b44f53
Merge pull request #617 from epage/update7eaf286
fix(parser): Failed on mixed inline tablese1f2037
test: Verify with latest data2f9253c
chore: Update toml-testc9b481c
test(toml): Ensure tables are used for validation43d7f29
Merge pull request #615 from toml-rs/renovate/actions-checkout-4.xef9b837
chore(deps): update actions/checkout action to v4d308188
chore: ReleaseDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major version
will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor version
will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>
will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>
will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>
will remove the ignore condition of the specified dependency and ignore conditions