Updated code to use the latest version of PyEnsign and added error handling for closed websocket connections #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sed websocket connections
|
This pull request has been linked to Shortcut Story #21689: Update the trades app to use the latest PyEnsign version. |
pdeziel
approved these changes
Oct 6, 2023
| async def handle_ack(ack): | ||
| _ = datetime.fromtimestamp(ack.committed.seconds + ack.committed.nanos / 1e9) | ||
|
|
||
| async def handle_nack(nack): | ||
| print(f"Could not commit event {nack.id} with error {nack.code}: {nack.error}") | ||
| logging.error(f"Could not commit event {nack.id} with error {nack.code}: {nack.error}") |
There was a problem hiding this comment.
Thanks for adding the logging!
| print(f"Websocket connection closed: {e}") | ||
| await asyncio.sleep(1) | ||
| logging.error(f"Websocket connection closed: {e}") | ||
| continue |
There was a problem hiding this comment.
Ok if I'm reading this correctly continue in this instance is the same as falling through to the next iteration right? So maybe it's not the cause of the app not publishing, but I think this is more clear anyway. Maybe the logging will help us figure out what's going on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The trades app was deployed before changes were made to PyEnsign to support the generator syntax. This PR updates the code to use the latest version of PyEnsign and ensures that the websocket connection is restored if the connection gets closed.
Prior to the websocket connection fix, the app stopped running after encountering this error:
Websocket connection closed: no close frame received or sentI ran the app overnight and was able to verify that it continues to run even after this error occurred.
@pdeziel - could you also test this on your machine before re-deploying the app? I had to downgrade river to version 0.15.0 due to the issue with the docker build on my machine.