Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse topic from protobuf #92

Merged
merged 2 commits into from
Nov 10, 2023
Merged

Parse topic from protobuf #92

merged 2 commits into from
Nov 10, 2023

Conversation

pdeziel
Copy link
Collaborator

@pdeziel pdeziel commented Nov 10, 2023

This PR adds a class to capture the deduplication settings from the topic and a method to parse topics from the protobuf into the user-facing class.

TODOs and questions

CHECKLIST

  • Is the commit message formatted correctly?
  • Do all of your functions and methods have docstrings?
  • Have you added/updated unit tests where appropriate?
  • Have you run the unit tests using pytest?
  • Is your code style correct (are you using PEP8, pyflakes)?

@shortcut-integration Shortcut Integration
Copy link

This pull request has been linked to Shortcut Story #22497: Better topic parsing.

pdamodaran
pdamodaran reviewed Nov 10, 2023
View reviewed changes
Copy link

@pdamodaran pdamodaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good @pdeziel! Thanks for adding the deduplication, offset strategy, and the status topics - this is a very useful feature!

@pdeziel pdeziel merged commit 721b5c7 into develop Nov 10, 2023
4 checks passed
@pdeziel pdeziel deleted the sc-22497 branch November 10, 2023 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdamodaran pdamodaran pdamodaran approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pdeziel @pdamodaran