Review Task Views

parlance/urls.py

@@ -33,9 +33,10 @@
 from django.contrib import admin
 from django.urls import path, include
 
+from parley.views import ReviewTaskDetail
 from parley.views import LLMList, LLMDetail
-from parley.views import UploaderFormView, CreateReviewTask, ResponseDetail
 from parlance.views import Dashboard, AccountSettings, AccountProfile
+from parley.views import UploaderFormView, CreateReviewTask, ResponseDetail
 from parley.views import EvaluationList, EvaluationDetail, DownloadPrompts
 
 
@@ -47,17 +48,21 @@
     # Application Pages
     path("", Dashboard.as_view(), name="dashboard"),
     path("upload/", UploaderFormView.as_view(), name="upload"),
+
     path("account/profile", AccountProfile.as_view(), name="account-profile"),
     path("account/settings", AccountSettings.as_view(), name="account-settings"),
+
     path("evaluations/", EvaluationList.as_view(), name="evaluations-list"),
     path("evaluations/<uuid:pk>", EvaluationDetail.as_view(), name="evaluation-detail"),
     path("evaluations/<uuid:pk>/download", DownloadPrompts.as_view(), name="evaluation-download"),
+    path("evaluations/create-review-task", CreateReviewTask.as_view(), name="create-review-task"),
+
+    path("reviews/<int:pk>", ReviewTaskDetail.as_view(), name="review-task"),
+
     path("models/", LLMList.as_view(), name="llms-list"),
     path("models/<uuid:pk>", LLMDetail.as_view(), name="llm-detail"),
     path("responses/<uuid:pk>", ResponseDetail.as_view(), name="response-detail"),
 
-    path("evaluations/create-review-task", CreateReviewTask.as_view(), name="create-review-task"),
-
     # Admin URLs
     path("admin/", admin.site.urls),
 

parlance/views.py

@@ -19,7 +19,7 @@
 
 from django.shortcuts import render
 from django.views.generic import TemplateView
-from parley.models import LLM, Evaluation, Prompt, Response
+from parley.models import LLM, Evaluation, Prompt, Response, ReviewTask
 
 
 ##########################################################################
@@ -41,7 +41,9 @@ def get_context_data(self, **kwargs):
         context["n_responses"] = Response.objects.count()
 
         # Get evaluations and models
-        context["evaluations"] = Evaluation.objects.filter(active=True)
+        context["evaluations"] = ReviewTask.objects.filter(
+            completed_on=None, user=self.request.user
+        )
         context["llms"] = LLM.objects.all()[:20]
 
         return context

parley/forms.py

@@ -187,8 +187,12 @@ class CreateReviewForm(forms.Form):
     def save(self):
         try:
             ReviewTask.objects.create(
-                user=User.objects.get(pk=self.cleaned_data["user"]),
-                evaluation=ModelEvaluation.objects.get(pk=self.cleaned_data["evaluation"]),
+                user=User.objects.get(
+                    pk=self.cleaned_data["user"]
+                ),
+                model_evaluation=ModelEvaluation.objects.get(
+                    pk=self.cleaned_data["evaluation"]
+                ),
             )
         except (User.DoesNotExist, ModelEvaluation.DoesNotExist):
             return

parley/migrations/0001_initial.py

@@ -1,4 +1,4 @@
-# Generated by Django 5.1.1 on 2024-10-07 01:00
+# Generated by Django 5.1.1 on 2024-10-07 03:15
 
 import django.db.models.deletion
 import parley.models.llm
@@ -704,7 +704,7 @@ class Migration(migrations.Migration):
                 "verbose_name": "response",
                 "verbose_name_plural": "responses",
                 "db_table": "responses",
-                "ordering": ("-created",),
+                "ordering": ("created",),
                 "get_latest_by": "created",
             },
         ),
@@ -814,6 +814,7 @@ class Migration(migrations.Migration):
                 (
                     "started_on",
                     models.DateTimeField(
+                        blank=True,
                         default=None,
                         help_text="The timestamp that the review was start on, null if not started",
                         null=True,
@@ -822,13 +823,14 @@ class Migration(migrations.Migration):
                 (
                     "completed_on",
                     models.DateTimeField(
+                        blank=True,
                         default=None,
                         help_text="The timestamp that the review was completed, null if not completed",
                         null=True,
                     ),
                 ),
                 (
-                    "evaluation",
+                    "model_evaluation",
                     models.ForeignKey(
                         help_text="The evaluation the user is performing",
                         on_delete=django.db.models.deletion.CASCADE,
@@ -856,7 +858,7 @@ class Migration(migrations.Migration):
                 "db_table": "review_tasks",
                 "ordering": ("-created",),
                 "get_latest_by": "created",
-                "unique_together": {("user", "evaluation")},
+                "unique_together": {("user", "model_evaluation")},
             },
         ),
         migrations.AddField(

parley/models/llm.py

@@ -282,6 +282,9 @@ class Meta:
     def image(self):
         return self.model.image
 
+    def prompts(self):
+        return self.evaluation.prompts.filter(exclude=False)
+
     def responses(self):
         return Response.objects.filter(
             model=self.model, prompt__evaluation=self.evaluation
@@ -423,7 +426,7 @@ class Response(BaseModel):
 
     class Meta:
         db_table = "responses"
-        ordering = ("-created",)
+        ordering = ("created",)
         get_latest_by = "created"
         verbose_name = "response"
         verbose_name_plural = "responses"

parley/models/user.py

@@ -20,6 +20,7 @@
 from .base import TimestampedModel
 
 from django.db import models
+from django.urls import reverse
 
 
 ##########################################################################
@@ -36,7 +37,7 @@ class ReviewTask(TimestampedModel):
         help_text="The user that is conducting the evaluation",
     )
 
-    evaluation = models.ForeignKey(
+    model_evaluation = models.ForeignKey(
         "parley.ModelEvaluation",
         null=False,
         on_delete=models.CASCADE,
@@ -49,20 +50,31 @@ class ReviewTask(TimestampedModel):
     )
 
     started_on = models.DateTimeField(
-        null=True, default=None,
+        null=True, default=None, blank=True,
         help_text="The timestamp that the review was start on, null if not started"
     )
 
     completed_on = models.DateTimeField(
-        null=True, default=None,
+        null=True, default=None, blank=True,
         help_text="The timestamp that the review was completed, null if not completed",
     )
 
     class Meta:
         db_table = "review_tasks"
         ordering = ("-created",)
         get_latest_by = "created"
-        unique_together = ("user", "evaluation")
+        unique_together = ("user", "model_evaluation")
+
+    @property
+    def evaluation(self):
+        return self.model_evaluation.evaluation
+
+    @property
+    def model(self):
+        return self.model_evaluation.model
+
+    def prompts(self):
+        return self.model_evaluation.prompts()
 
     @property
     def is_started(self):
@@ -72,6 +84,20 @@ def is_started(self):
     def is_completed(self):
         return self.completed_on is not None
 
+    @property
+    def percent_complete(self):
+        n_prompts = self.prompts().count()
+        if n_prompts == 0:
+            return 0
+        n_reviews = self.response_reviews.count()
+        return int((float(n_reviews) / float(n_prompts)) * 100)
+
+    def __str__(self):
+        return f"{self.evaluation.name} ({self.model.name})"
+
+    def get_absolute_url(self):
+        return reverse("review-task", args=(self.id,))
+
 
 class ResponseReview(TimestampedModel):
 
@@ -87,7 +113,7 @@ class ResponseReview(TimestampedModel):
         'parley.Response',
         null=False,
         on_delete=models.CASCADE,
-        related_name=("reviews"),
+        related_name="reviews",
     )
 
     output_correct = models.BooleanField(

parley/signals.py

@@ -17,10 +17,11 @@
 ## Imports
 ##########################################################################
 
+from django.utils import timezone
 from django.dispatch import receiver
 from django.db.models.signals import post_save, post_delete
 
-from parley.models import Response, ModelEvaluation
+from parley.models import Response, ModelEvaluation, ResponseReview
 
 
 ##########################################################################
@@ -61,3 +62,49 @@ def model_evaluation_unlink(sender, instance, *args, **kwargs):
             ModelEvaluation.objects.get(**kwargs).delete()
         except ModelEvaluation.DoesNotExist:
             pass
+
+
+##########################################################################
+## Ensure ReviewTasks are
+##########################################################################
+
+@receiver(post_save, sender=ResponseReview, dispatch_uid="check_review_task_completion")
+def check_review_task_completion(sender, instance, created, *args, **kwargs):
+    task = instance.review
+    changed = False
+
+    if not task.started_on:
+        task.started_on = timezone.localtime()
+        changed = True
+
+    if not task.completed_on:
+        n_prompts = task.prompts().count()
+        if n_prompts == 0 or task.response_reviews.count() == n_prompts:
+            task.completed_on = timezone.localtime()
+            changed = True
+
+    if changed:
+        task.save()
+
+
+@receiver(post_delete, sender=ResponseReview, dispatch_uid="check_review_task_unfinished")
+def check_review_task_unfinished(sender, instance, *args, **kwargs):
+    task = instance.review
+    if task.completed_on:
+        n_prompts = task.prompts().count()
+        if n_prompts == 0:
+            return
+
+        n_reviews = task.response_reviews.count()
+        changed = False
+
+        if n_reviews < n_prompts:
+            task.completed_on = None
+            changed = True
+
+        if n_reviews == 0:
+            task.started_on = None
+            changed = True
+
+        if changed:
+            task.save()

parley/templates/evaluation/detail.html

@@ -82,9 +82,13 @@ <h4 class="mb-1 name">
 
                   {% get_review_task user model as review_task %}
                   {% if review_task %}
+                  {% if review_task.is_completed %}
+                  <span class="badge py-2 text-bg-success">Review Complete!</span>
+                  {% else %}
                   <a href="{{ review_task.get_absolute_url }}" class="btn btn-sm btn-white d-none d-xl-inline-block">
                     Continue Review
                   </a>
+                  {% endif %}
                   {% else %}
                   <form action="{% url 'create-review-task' %}" method="post" class="m-0 p-0 d-inline-block">
                     <input type="hidden" name="user" value="{{ user.id }}" />
@@ -96,6 +100,26 @@ <h4 class="mb-1 name">
                   </form>
                   {% endif %}
                 </div>
+                <div class="col-auto">
+
+                  <!-- Dropdown -->
+                  <div class="dropdown">
+                    <a href="#" class="dropdown-ellipses dropdown-toggle" role="button" data-bs-toggle="dropdown" aria-haspopup="true" aria-expanded="false">
+                      <i class="fe fe-more-vertical"></i>
+                    </a>
+                    <div class="dropdown-menu dropdown-menu-end">
+                      {% if user.is_staff %}
+                      <a href="{% url 'admin:parley_modelevaluation_change' model.pk %}" class="dropdown-item">
+                        Edit in CMS
+                      </a>
+                      {% endif %}
+                      <a href="{% url 'llm-detail' model.model.pk %}" class="dropdown-item">
+                        View Model
+                      </a>
+                    </div>
+                  </div>
+
+              </div>
               </div>
             </li>
             {% empty %}

parley/templates/reviews/detail.html

@@ -0,0 +1,4 @@
+{% extends 'page.html' %}
+
+{% block page-pretitle %}Reviews{% endblock %}
+{% block page-title %}{{ review }}{% endblock %}

parley/templatetags/parlance.py

@@ -46,6 +46,6 @@ def alert_level(level):
 @register.simple_tag()
 def get_review_task(user, evaluation):
     try:
-        return ReviewTask.objects.get(user=user, evaluation=evaluation)
+        return ReviewTask.objects.get(user=user, model_evaluation=evaluation)
     except ReviewTask.DoesNotExist:
         return None

parley/views.py

@@ -31,7 +31,7 @@
 
 from parley.exceptions import ParlanceUploadError
 from parley.forms import Uploader, CreateReviewForm
-from parley.models import LLM, Response, Evaluation, Prompt
+from parley.models import LLM, Response, Evaluation, Prompt, ReviewTask
 
 
 ##########################################################################
@@ -194,3 +194,15 @@ def form_invalid(self, form):
 
     def get(self, *args, **kwargs):
         return HttpResponseNotAllowed(['POST'])
+
+
+class ReviewTaskDetail(DetailView):
+
+    model = ReviewTask
+    template_name = "reviews/detail.html"
+    context_object_name = "review"
+
+    def get_context_data(self, **kwargs):
+        context = super().get_context_data(**kwargs)
+        context["page_id"] = "review"
+        return context