Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PBs for SetTopicPolicy #28

Merged
merged 3 commits into from
Oct 11, 2023
Merged

Update PBs for SetTopicPolicy #28

merged 3 commits into from
Oct 11, 2023

Conversation

bbengfort
Copy link
Contributor

@bbengfort bbengfort commented Oct 5, 2023

Scope of changes

This PR updates the SDK protocol buffers to reflect upcoming Ensign v0.11.0 changes including the SetTopicPolicy RPC.

Fixes SC-21883

Relates to rotationalio/ensign#773 and rotationalio/pyensign#73

Type of change

  • new feature
  • bug fix
  • documentation
  • testing
  • technical debt
  • other (describe)

Acceptance criteria

Users can use the Go-Ensign SDK to change the deduplication policy of topics.

Author checklist

  • I have manually tested the change and/or added automation in the form of unit tests or integration tests
  • I have updated the dependencies list
  • I have recompiled and included new protocol buffers to reflect changes I made
  • I have added new test fixtures as needed to support added tests
  • Check this box if a reviewer can merge this pull request after approval (leave it unchecked if you want to do it yourself)
  • I have moved the associated Shortcut story to "Ready for Review"

Reviewer(s) checklist

  • Any new user-facing content that has been added for this PR has been QA'ed to ensure correct grammar, spelling, and understandability.
  • Are there any TODOs in this PR that should be turned into stories?

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #21883: Update SDKs with SetTopicPolicy RPC.

@bbengfort bbengfort marked this pull request as ready for review October 6, 2023 19:44
@bbengfort bbengfort merged commit 83891e8 into main Oct 11, 2023
@bbengfort bbengfort deleted the sc-21883 branch October 11, 2023 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant