Upgrades dependencies and node version #836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniellemaxwell
commented
Jul 9, 2024
| @@ -52,7 +52,6 @@ const router = createBrowserRouter( | |||
| <Route path="dashboard" element={<Home />} /> | |||
| <Route path="projects"> | |||
| <Route index element={<ProjectsPage />} /> | |||
| <Route path=":project-setup" element={<>Project setup</>} /> | |||
There was a problem hiding this comment.
The route has been removed since it's not used and it was causing a blank page with Project setup to appear instead of the ProjectDetailPage in dev.
pdeziel
approved these changes
Jul 9, 2024
| @@ -52,7 +52,6 @@ const router = createBrowserRouter( | |||
| <Route path="dashboard" element={<Home />} /> | |||
| <Route path="projects"> | |||
| <Route index element={<ProjectsPage />} /> | |||
| <Route path=":project-setup" element={<>Project setup</>} /> | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope of changes
This PR updates dependencies and the node version in the Docker compose file. A follow on story will be created to update dependencies that require Node v18+.
Fixes SC-26268
Type of change
Acceptance criteria
Build passes
Definition of Done
Reviewer(s) checklist