Cache model so it doesn't break trying to re-compile #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I accidentally made the pull request here, but well, maybe it can be useful to you or someone. In my scenario I had a code from long ago that was using the version from npm. The problem is: that version doesn't work with npm 5, in the system I changed it was using npm 1.4... I found your fork and I thought it was a nice one. But when I tried to migrate my code I kept running in an error that would say the model was already compiled and the application would exit. So I investigated this package's code and saw that there was a cache system, but apparently that's not being used. I changed the code so it uses that caching system, and with that it no longer breaks on multiple uses. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.