This repository has been archived by the owner on Aug 11, 2023. It is now read-only.
Fix: avoid exceptions on node shutdown #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e topic. - Minor nits for ParameterLoaderNode
|
@jubeira sorry I wasn't more helpful on this one. Nice work on this fix. Let me know if you need me to look at anything else relating to this. |
|
No prob @stratomda ! Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes [part of] #241 .
Now no exceptions are thrown when a node is shut down in the case that the node is connected to a topic that has subscribers. I will close #241 and open another one to track the exception when the topic (only the topic, not the node) is shut down once this is merged.
I also corrected some nits for ParameterLoader.