-
Notifications
You must be signed in to change notification settings - Fork 59
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
I only have one comment regarding this. I think this is good to have even if not all the tests are passing; we can fix them in future PRs.
} | ||
|
||
@Test | ||
public void testChannelBufferFixedSizeNoInitialization() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the difference between this test and a simple byte array? Should we add a byte array test too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. I will see to add tests for byte arrays, although according to this comment ChannelBuffer is the preferred way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found this in the RawMessage
interface:
/**
* @deprecated replaced by {@link #setInt8(String, byte)}
*/
void setByte(String name, byte value);
/**
* @deprecated replaced by {@link #setInt8Array(String, byte[])}
*/
void setByteArray(String name, byte[] value);
/**
* @deprecated replaced by {@link #setUInt8(String, byte)}
*/
void setChar(String name, short value);
/**
* @deprecated replaced by {@link #setUInt8Array(String, byte[])}
*/
void setCharArray(String name, short[] value);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ernestmc; you already have my approval :) |
Adds unit test cases for fixed sized arrays with different data types.
Note that currently some tests are not passing and will be addressed in future pull requests like #59 which is pending review.
To run the tests:
Here's a snapshot of the current status of the tests: