Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

214 roughness update defaults #216

Merged
merged 5 commits into from
Oct 27, 2023
Merged

214 roughness update defaults #216

merged 5 commits into from
Oct 27, 2023

Conversation

rosepearson
Copy link
Owner

@rosepearson rosepearson commented Oct 27, 2023 •
edited
Loading

Support NaN for waterways, minimum or maximum roughness default values:

  • Make code change
  • Update tests
    • Update / create new tests
    • Ensure these tests have the expected behavour
    • Test locally and ensure tests are passing
  • Ensure tests passing on GH Actions
  • Update documentation
    • Doc strings
    • Wiki
  • Update package (version.py & pyproject.toml) version (if needed)

@rosepearson
Support a nan for default roughness values
6e45ffb 
Is null/nan for waterways, min or max - the roughness is not changed.
Update an test to reflect theses changes.
Update the default maximum roughness.
@rosepearson
Update contributors.yml
bbf592e
@rosepearson rosepearson linked an issue Oct 27, 2023 that may be closed by this pull request
roughness - support nan of defaults = no action #214
Closed
@rosepearson rosepearson merged commit 49211e2 into main Oct 27, 2023
@rosepearson rosepearson deleted the 214-roughness-update-defaults branch October 27, 2023 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

roughness - support nan of defaults = no action
1 participant
@rosepearson