-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added new IDEs page and started filling it in for PyCharm #4023
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i had a few minor comments, i believe this is a good start to list the IDEs for ROS 2 documentation.
source/How-To-Guides/Setup-ROS-2-with-VSCode-and-Docker-Container.rst
Outdated
Show resolved
Hide resolved
60d2940
to
4d6a4d3
Compare
source/Tutorials/Beginner-Client-Libraries/Creating-A-Workspace/Creating-A-Workspace.rst
Outdated
Show resolved
Hide resolved
source/How-To-Guides/Setup-ROS-2-with-VSCode-and-Docker-Container.rst
Outdated
Show resolved
Hide resolved
b3d2a3a
to
b03b17b
Compare
@clalancette thanks for your review. What do you think about the above? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more things to update; this is starting to look good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies, one last change to the title. Then this will be good.
@clalancette thanks again. |
Co-authored-by: Chris Lalancette <[email protected]> Signed-off-by: Robert <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, thanks for the iteration here.
* Added new IDEs page and started filling it in for PyCharm * Changed style of labels + Added link to Colcon build * Added note about package dependencies Signed-off-by: Robert <[email protected]> Co-authored-by: Chris Lalancette <[email protected]> (cherry picked from commit 8d6eb04)
* Added new IDEs page and started filling it in for PyCharm * Changed style of labels + Added link to Colcon build * Added note about package dependencies Signed-off-by: Robert <[email protected]> Co-authored-by: Chris Lalancette <[email protected]> (cherry picked from commit 8d6eb04)
) * Added new IDEs page and started filling it in for PyCharm * Changed style of labels + Added link to Colcon build * Added note about package dependencies Signed-off-by: Robert <[email protected]> Co-authored-by: Chris Lalancette <[email protected]> (cherry picked from commit 8d6eb04) Co-authored-by: Robert <[email protected]>
) * Added new IDEs page and started filling it in for PyCharm * Changed style of labels + Added link to Colcon build * Added note about package dependencies Signed-off-by: Robert <[email protected]> Co-authored-by: Chris Lalancette <[email protected]> (cherry picked from commit 8d6eb04) Co-authored-by: Robert <[email protected]>
To fix #4022 , as a migration of http://wiki.ros.org/IDEs.
I'm not sure yet if we should move the current content of the VSCode/Docker How-To into this page, or we keep just a link to it.