Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new IDEs page and started filling it in for PyCharm #4023

Merged
merged 6 commits into from
Nov 27, 2023

Conversation

RobertoRoos
Copy link
Contributor

To fix #4022 , as a migration of http://wiki.ros.org/IDEs.

I'm not sure yet if we should move the current content of the VSCode/Docker How-To into this page, or we keep just a link to it.

Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i had a few minor comments, i believe this is a good start to list the IDEs for ROS 2 documentation.

source/How-To-Guides/ROS-2-IDEs.rst Outdated Show resolved Hide resolved
source/How-To-Guides/ROS-2-IDEs.rst Outdated Show resolved Hide resolved
source/How-To-Guides/ROS-2-IDEs.rst Outdated Show resolved Hide resolved
source/How-To-Guides/ROS-2-IDEs.rst Outdated Show resolved Hide resolved
source/How-To-Guides/ROS-2-IDEs.rst Outdated Show resolved Hide resolved
source/How-To-Guides/ROS-2-IDEs.rst Outdated Show resolved Hide resolved
source/How-To-Guides/ROS-2-IDEs.rst Outdated Show resolved Hide resolved
source/How-To-Guides/ROS-2-IDEs.rst Show resolved Hide resolved
source/How-To-Guides/ROS-2-IDEs.rst Show resolved Hide resolved
source/How-To-Guides/ROS-2-IDEs.rst Outdated Show resolved Hide resolved
@RobertoRoos
Copy link
Contributor Author

@clalancette thanks for your review. What do you think about the above?

Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more things to update; this is starting to look good!

source/How-To-Guides/ROS-2-IDEs.rst Outdated Show resolved Hide resolved
source/How-To-Guides/ROS-2-IDEs.rst Outdated Show resolved Hide resolved
source/How-To-Guides/ROS-2-IDEs.rst Outdated Show resolved Hide resolved
source/How-To-Guides/ROS-2-IDEs.rst Show resolved Hide resolved
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies, one last change to the title. Then this will be good.

source/How-To-Guides/ROS-2-IDEs.rst Outdated Show resolved Hide resolved
@RobertoRoos
Copy link
Contributor Author

@clalancette thanks again.
I added a new paragraph about package dependencies. Let me know if you want to tackle that in a second PR, then I'll force-push it out of here.

Co-authored-by: Chris Lalancette <[email protected]>
Signed-off-by: Robert <[email protected]>
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thanks for the iteration here.

@clalancette clalancette added the backport-all backport at reviewers discretion; from rolling to all versions label Nov 27, 2023
@clalancette clalancette merged commit 8d6eb04 into ros2:rolling Nov 27, 2023
3 checks passed
mergify bot pushed a commit that referenced this pull request Nov 27, 2023
* Added new IDEs page and started filling it in for PyCharm

* Changed style of labels + Added link to Colcon build

* Added note about package dependencies

Signed-off-by: Robert <[email protected]>
Co-authored-by: Chris Lalancette <[email protected]>
(cherry picked from commit 8d6eb04)
mergify bot pushed a commit that referenced this pull request Nov 27, 2023
* Added new IDEs page and started filling it in for PyCharm

* Changed style of labels + Added link to Colcon build

* Added note about package dependencies

Signed-off-by: Robert <[email protected]>
Co-authored-by: Chris Lalancette <[email protected]>
(cherry picked from commit 8d6eb04)
clalancette pushed a commit that referenced this pull request Nov 27, 2023
)

* Added new IDEs page and started filling it in for PyCharm

* Changed style of labels + Added link to Colcon build

* Added note about package dependencies

Signed-off-by: Robert <[email protected]>
Co-authored-by: Chris Lalancette <[email protected]>
(cherry picked from commit 8d6eb04)

Co-authored-by: Robert <[email protected]>
clalancette pushed a commit that referenced this pull request Nov 27, 2023
)

* Added new IDEs page and started filling it in for PyCharm

* Changed style of labels + Added link to Colcon build

* Added note about package dependencies

Signed-off-by: Robert <[email protected]>
Co-authored-by: Chris Lalancette <[email protected]>
(cherry picked from commit 8d6eb04)

Co-authored-by: Robert <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-all backport at reviewers discretion; from rolling to all versions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IDEs page for ROS2
4 participants