add note for LoanedMessages's unsafety issue and setting. #4002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomoya.Fujita <[email protected]>
fujitatomoya
requested review from
clalancette
and removed request for
clalancette and
audrow
fujitatomoya
commented
Nov 3, 2023
clalancette
requested changes
Nov 6, 2023
There was a problem hiding this comment.
I kind of feel like we should rewrite the beginning of this article, rather than adding in a .. note. That is, the top says that by default, it will try to borrow memory, which just is not true anymore. I think we can move the contents of the note to that opening paragraph, and this whole thing will be a lot clearer.
|
yeah, that is better. i will try to do that. |
Signed-off-by: Tomoya.Fujita <[email protected]>
Signed-off-by: Tomoya.Fujita <[email protected]>
|
@clalancette applied your suggestion to rewrite the doc for this, requesting another look! thanks in advance. |
clalancette
requested changes
Nov 20, 2023
clalancette
requested changes
Nov 27, 2023
Signed-off-by: Tomoya.Fujita <[email protected]>
fujitatomoya
force-pushed
the
fujitatomoya/doc-for-rcl-pull-1110
branch
from
b375c17 to
e9e3cb1
Compare
clalancette
added
the
backport-all
clalancette
approved these changes
Nov 27, 2023
delete-merged-branch
bot
deleted the
fujitatomoya/doc-for-rcl-pull-1110
branch
mergify bot
pushed a commit
that referenced
this pull request
Nov 27, 2023
* add note for LoanedMessages's unsafety issue and setting. * add redirection from previous file. Signed-off-by: Tomoya.Fujita <[email protected]> (cherry picked from commit 97bd9fe)
mergify bot
pushed a commit
that referenced
this pull request
Nov 27, 2023
* add note for LoanedMessages's unsafety issue and setting. * add redirection from previous file. Signed-off-by: Tomoya.Fujita <[email protected]> (cherry picked from commit 97bd9fe)
This was referenced Nov 27, 2023
clalancette
pushed a commit
that referenced
this pull request
Nov 27, 2023
) * add note for LoanedMessages's unsafety issue and setting. * add redirection from previous file. Signed-off-by: Tomoya.Fujita <[email protected]> (cherry picked from commit 97bd9fe) Co-authored-by: Tomoya Fujita <[email protected]>
clalancette
pushed a commit
that referenced
this pull request
Nov 27, 2023
) * add note for LoanedMessages's unsafety issue and setting. * add redirection from previous file. Signed-off-by: Tomoya.Fujita <[email protected]> (cherry picked from commit 97bd9fe) Co-authored-by: Tomoya Fujita <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc update for ros2/rcl#1110