Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Building-a-Visual-Robot-Model-with-URDF-from-Scratch.rst #3071

Merged
merged 1 commit into from
Oct 3, 2022

Conversation

m-elwin
Copy link
Contributor

@m-elwin m-elwin commented Oct 3, 2022

I believe the bug with respect to locale was fixed a while back ros/urdfdom_headers#42 so setting LC_NUMERIC is no longer necessary

I believe the bug with respect to locale was fixed a while back ros/urdfdom_headers#42 so setting LC_NUMERIC is no longer necessary
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you are right. This should have been fixed long ago, though it is honestly not that easy for me to test it out. That said, I think we should go ahead with this and we'll see if anyone complains.

@clalancette clalancette merged commit 611f948 into ros2:humble Oct 3, 2022
@clalancette
Copy link
Contributor

@Mergifyio backport rolling foxy galactic

mergify bot pushed a commit that referenced this pull request Oct 3, 2022
I believe the bug with respect to locale was fixed a while back ros/urdfdom_headers#42 so setting LC_NUMERIC is no longer necessary

(cherry picked from commit 611f948)
mergify bot pushed a commit that referenced this pull request Oct 3, 2022
I believe the bug with respect to locale was fixed a while back ros/urdfdom_headers#42 so setting LC_NUMERIC is no longer necessary

(cherry picked from commit 611f948)
@mergify
Copy link
Contributor

mergify bot commented Oct 3, 2022

backport rolling foxy galactic

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Oct 3, 2022
I believe the bug with respect to locale was fixed a while back ros/urdfdom_headers#42 so setting LC_NUMERIC is no longer necessary

(cherry picked from commit 611f948)
clalancette pushed a commit that referenced this pull request Oct 3, 2022
… (#3072)

I believe the bug with respect to locale was fixed a while back ros/urdfdom_headers#42 so setting LC_NUMERIC is no longer necessary

(cherry picked from commit 611f948)

Co-authored-by: Matthew Elwin <[email protected]>
clalancette pushed a commit that referenced this pull request Oct 3, 2022
… (#3073)

I believe the bug with respect to locale was fixed a while back ros/urdfdom_headers#42 so setting LC_NUMERIC is no longer necessary

(cherry picked from commit 611f948)

Co-authored-by: Matthew Elwin <[email protected]>
clalancette pushed a commit that referenced this pull request Oct 3, 2022
… (#3074)

I believe the bug with respect to locale was fixed a while back ros/urdfdom_headers#42 so setting LC_NUMERIC is no longer necessary

(cherry picked from commit 611f948)

Co-authored-by: Matthew Elwin <[email protected]>
@m-elwin m-elwin deleted the patch-2 branch October 5, 2022 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants