README: add '-b <DISTRO>' to git clone instruction #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Timple
reviewed
Dec 23, 2024
| @@ -23,7 +23,7 @@ See [zenoh_cpp_vendor/CMakeLists.txt](./zenoh_cpp_vendor/CMakeLists.txt) for mor | |||
|
|
|||
| ```bash | |||
| mkdir ~/ws_rmw_zenoh/src -p && cd ~/ws_rmw_zenoh/src | |||
| git clone https://github.com/ros2/rmw_zenoh.git | |||
| git clone https://github.com/ros2/rmw_zenoh.git -b <DISTRO> | |||
There was a problem hiding this comment.
If you make it -b $ROS_DISTRO it's just as readable but also copy-pastable.
There was a problem hiding this comment.
I agree! I was just complying with the other instructions below which are using <DISTRO> instead of $ROS_DISTRO.
@Yadunund any reason for not having used $ROS_DISTRO in the very first version of this README ?
There was a problem hiding this comment.
Probably because we don't source the distro till a couple steps after so the ROS_DISTRO envar will not be set at this point.
Anyways, I have the -b flag added in this PR #356 so we can close this PR out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that there are separate branches for each distribution and the
rollingbranch can no longer be compiled on Jazzy, the build instructions need to be updated to guide users to clone the correct branch.