Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this fix, what we do is to manually allocate a struct that wraps the ClientData. Inside of that struct, we take a
shared_ptr
reference toClientData
. And then inclient_data_drop
, we manually delete the struct.This ensures that the
ClientData
object is not destroyed while there are still requests in-flight. This also allows us to get rid of the tricky tracking of thenum_in_flight
; we don't need it anymore, and thermw_node_data_t
can just drop the reference directly.Finally, I'll note that this is basically equivalent to do a lambda capture when zenoh-cpp. Still, I think this is worthwhile getting in before #327 since it fixes UB and it is relatively easy to understand.