Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safely convert from uint64_t to size_t. #9

Merged
merged 4 commits into from
Jun 3, 2019
Merged

Safely convert from uint64_t to size_t. #9

merged 4 commits into from
Jun 3, 2019

Conversation

malsbat
Copy link
Collaborator

@malsbat malsbat commented May 15, 2019

This fixes #8.

Signed-off-by: Todd Malsbary [email protected]

This fixes #8.

Signed-off-by: Todd Malsbary <[email protected]>
@malsbat
Copy link
Collaborator Author

malsbat commented May 15, 2019

@alsora, I can't seem to add you as a reviewer. Please leave a comment if this fixes #8.

Copy link
Contributor

@GregBurns GregBurns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably want an explicit cast to size_t to avoid potential warnings

@alsora
Copy link
Contributor

alsora commented May 16, 2019

Thank you, this fixes #8 .

However, during my previous cross-compilation I haven't noticed that the underlying DPS library was not receiving the cross-compilation flags.
As a result DPS was still built for X86_64.

If I try to build DPS on 32 bit I get several similar errors.

For this reason I think that this PR should wait for DPS to be eventually updated with intel/dps-for-iot#96

@malsbat
Copy link
Collaborator Author

malsbat commented May 16, 2019

I started an x86 branch for DPS here: https://github.com/intel/dps-for-iot/tree/x86.

@malsbat
Copy link
Collaborator Author

malsbat commented Jun 3, 2019

I'm going to merge this as it addresses the immediate issue. The general cross-compilation of rmw_dps will be done in a different PR.

@malsbat malsbat merged commit 91f775d into master Jun 3, 2019
@delete-merged-branch delete-merged-branch bot deleted the issue_8 branch June 3, 2019 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

size_t cross-compilation issue
3 participants