install net-tools for ifconfig in docker image

[wjwwood]

fixes ros2/build_farmer#26

[mikaelarguedas]

lgtm, I don't think this requires CI to be merged

[dhood]

I think it might need CI for ARM given #75

[mikaelarguedas]

I think it might need CI for ARM given #75

Yeah, this is in the middle of a series of very similar commands without any add commande before so it would be very surprising. I'll leave it up to @wjwwood to run CI or not

[wjwwood]

I started a job just to make sure if got rid of the ifconfig missing issue:

http://ci.ros2.org/job/ci_linux/2651/console

It looks good, but I'll also run an ARM job as @dhood suggested.

[dhood]

Now that I remember what originally caused that issue to appear, I also launched because it was the extra lines that are only in the turtlebot dockerfile that caused it to show up on ARM (#74)

[wjwwood]

Thanks @dhood the ARM job passed docker and the issue was fixed:

http://ci.ros2.org/job/ci_linux-aarch64/206/console

I'll wait for the job you launched to get past docker before merging.

[wjwwood]

@dhood did it fail in the same way?

[dhood]

yes, unfortunately. there's an issue linked to in this comment that might have the permanent fix, but the temporary workaround is to merge lines in the dockerfile (we're hitting some layer limit)

[wjwwood]

I'm going to try again with ab4085f

[mikaelarguedas]

My bad, I thought it was related to the type of command not the number of layers. Thanks @dhood for checking

[mikaelarguedas]

Maybe we should rename #75 accordingly now that we know more about the issue

[wjwwood]

http://ci.ros2.org/job/ci_linux-aarch64/207/console is working, so I'll merge this.