Return to using qt online installer by default. #538
Conversation
This change in tandem with refactored qt5 recipes will allow us to use either the qt5 online installer with the latest version of qt5 on Windows or the 5.12 offline installer. This is designed to be used whenever the Qt5 online installer is unavailable. Since the offline installer stopped being made available for open source builds after 5.12 it is not recommended unless the online installer is unusable.
|
Checking the online installer: |
|
Checking the offline installer |
This reverts commit cb77f9a.
|
Having tested the offline installer logic I reverted the commit which switched to it. Before merging here we should get reviews on the cookbook PR so that the last commit on this PR will return us to the |
|
One last build to make sure that there are no regressions after the merge onto latest |
|
I'm not positive but I think that since this PR I have not been able to have any successful windows builds e.g. https://ci.ros2.org/job/ci_windows/13592/console |
|
Investigating now. Due to the nature of docker cache-busting I'm not sure whether a revert will immediately bring CI back online but I'll try that first. |
This reverts commit 2d6b2bd.
|
@emersonknapp the revert has been merged so CI should be unblocked. Thanks for reporting |
This change in tandem with refactored qt5 recipes will allow us to use
either the qt5 online installer with the latest version of qt5 on
Windows or the 5.12 offline installer. This is designed to be used
whenever the Qt5 online installer is unavailable. Since the offline
installer stopped being made available for open source builds after
5.12 it is not recommended unless the online installer is unusable.