Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install opensplice on aarch64 #100

Merged
merged 2 commits into from
Sep 13, 2017
Merged

Install opensplice on aarch64 #100

merged 2 commits into from
Sep 13, 2017

Conversation

sloretz
Copy link
Contributor

@sloretz sloretz commented Sep 13, 2017

This updates the dockerfile to install libopensplice67 on arm. The package would come from http://packages.osrfoundation.org/gazebo/ubuntu-stable/dists/xenial/main/binary-arm64/Packages. It is intented to fix the failure seen in http://ci.ros2.org/job/packaging_linux-aarch64/171/console

  • Packaging Linux Build Status

@sloretz sloretz added in progress Actively being worked on (Kanban column) in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Sep 13, 2017
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems reasonable to me; I'm fine with it as long as the CI completes.

@sloretz
Copy link
Contributor Author

sloretz commented Sep 13, 2017

First CI will fail, looks like the platform arg to docker is arm instead of aarch64 :(

Rerunning.

@dhood
Copy link
Member

dhood commented Sep 13, 2017

@sloretz FYI we have CI versions of the packaging jobs for testing changes to the jobs (we try to avoid triggering the standard packaging jobs with non-default parameters)

@sloretz sloretz merged commit 636bae6 into master Sep 13, 2017
@sloretz sloretz removed the in review Waiting for review (Kanban column) label Sep 13, 2017
@sloretz sloretz deleted the sloretz-arm-opensplice branch September 13, 2017 17:41
@dhood
Copy link
Member

dhood commented Sep 14, 2017

Looks like this change pushed us back over the layer limit encounted building the turtlebot demo: Build Status. We could only install it if it's selected which would buy us some time, or follow up on proposals in #75

@dirk-thomas
Copy link
Member

We could only install it if it's selected

That would also imply that we don't reuse the docker images when toggling the option. Therefore I would suggest to "collapse" some other line to get back under the limit as a short term workaround.

@sloretz
Copy link
Contributor Author

sloretz commented Sep 14, 2017

There are quite a few layers that could be collapsed. These 3 could become one.

# net-tools is for ifconfig
RUN apt-get update && apt-get install --no-install-recommends -y lsb-release net-tools sudo
# Get curl for fetching the repo keys.
RUN apt-get update && apt-get install --no-install-recommends -y curl
# Get https transport for APT.
RUN apt-get update && apt-get install --no-install-recommends -y apt-transport-https

As could these

RUN apt-get update && apt-get install --no-install-recommends -y libasio-dev libssl-dev libtinyxml2-dev valgrind
# Install OpenCV.
RUN apt-get update && apt-get install --no-install-recommends -y libopencv-dev
# Install build dependencies for class loader.
RUN apt-get update && apt-get install --no-install-recommends -y libpoco-dev libpocofoundation9v5 libpocofoundation9v5-dbg
# Install dependencies for robot_model and robot_state_publisher
RUN apt-get update && apt-get install --no-install-recommends -y libtinyxml-dev libeigen3-dev
# Install Python3 development files.
RUN apt-get update && apt-get install --no-install-recommends -y python3-dev

@dirk-thomas
Copy link
Member

If the first block is enough for now I would start with those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants