Add in some tests for the strToDouble conversion. #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that this only tests that some simple cases do the correct thing. We can't reliably check the locale fixing code because we can't depend on any particular locales being installed on test machines. Signed-off-by: Chris Lalancette <[email protected]>
scpeters
reviewed
Feb 21, 2018
urdf_parser/test/CMakeLists.txt
Outdated
| @@ -20,7 +20,9 @@ include_directories(${GTEST_INCLUDE_DIRS}) | |||
|
|
|||
| # unit test to fix geometry problems | |||
| set(tests | |||
| urdf_unit_test.cpp) | |||
| urdf_unit_test.cpp | |||
| urdf_double_convert.cpp | |||
There was a problem hiding this comment.
alphabetize the list please
There was a problem hiding this comment.
Whoops, sorry. Done now.
|
In 0e14f00 I made a test commit that will use the |
Signed-off-by: Chris Lalancette <[email protected]>
scpeters
approved these changes
Feb 21, 2018
|
CI looks good on my test branch |
|
I'm actually going to close this out and re-open to re-trigger Travis now that ros/urdfdom_headers#42 has been merged. |
|
The "push" one is failing, but that's because it ran before the urdfdom_headers PR was in. Since the other Travis CI looks good, I'm going to merge this. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this only tests that some simple cases do the correct
thing. We can't reliably check the locale fixing
code because we can't depend on any particular locales being
installed on test machines.
This depends on ros/urdfdom_headers#42, so should not be merged until that one is.
Signed-off-by: Chris Lalancette [email protected]