-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rosdep] no more distutils as of Python 3.12 #43500
base: master
Are you sure you want to change the base?
Conversation
https://peps.python.org/pep-0632/ Signed-off-by: Mikael Arguedas <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, hm. I'm not sure what to do here.
For Fedora, Gentoo, and nixOS, it looks like we set this to "python" long ago (2020, it looks like). But that is actually a lie.
What I'd be in favor of here is removing all stanzas here except for the Ubuntu versions it can still be installed on, and the Debian versions it can still be installed on. That way we'll be consistent everywhere. In other words, remove fedora, gentoo, and nixos stanzas as well.
It wasn't at the time. Python 3.11 and older provide I do however agree that platforms targeting Python >= 3.12 should drop rules now, which includes Fedora. |
Also note that |
oh I forgot about that, thanks for the info! |
So to move forward on this I should identify which version of fedora ship what version of python and just keep the non-EOL anes and update the rules ? not familiar with gentoo and nixOS so I may need assistance finding out what to do there |
I see, thanks for the info.
Hm, though now I think it might be provided by
|
It might on some platforms, yes. On Fedora, a |
I think we should decide whether or not we want to seamlessly transition to the setuptools shim (which will doubtless get dropped in some major version unceremoniously, possibly even in the near future) or if we think that people depending on setuptools to provide distutils should update their dependency declaration explicitly. |
As per PEP 632 https://peps.python.org/pep-0632/ distutils has been deprecated from Python 3.10 and is not distributed as of Python 3.12.
The package cannot be installed on newer platforms.
Distro packaging links:
Links to Distribution Packages
This PR mark explicitly past distros as providing the package and defaults to null for all other distros.
Not sure how to deal with other distros that juste reference python standard library