Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jacro: 0.2.0-1 in 'rolling/distribution.yaml' [bloom] #43494

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JafarAbdi
Copy link
Contributor

Increasing version of package(s) in repository jacro to 0.2.0-1:

jacro

* Replace minijinja with jinja2
* Contributors: JafarAbdi

@github-actions github-actions bot added the rolling Issue/PR is for the ROS 2 Rolling distribution label Nov 13, 2024
Copy link
Member

@Yadunund Yadunund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New package review checklist

  • At least one of the following must be present
    • Top level license file:
    • Per package license files:
  • License is OSI-approved: BSD-3-Clause
  • License correctly listed in package.xmls
  • Public source repo: https://github.com/JafarAbdi/jacro.git
  • Source repository contains ROS packages
  • Each package meets REP-144 naming conventions

Left some comments to consider and will wait for secondary approval from @sloretz before we merge this.

release:
tags:
release: release/rolling/{package}/{version}
url: https://github.com/JafarAbdi/jacro-release.git
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to consider housing the release repo in the ros2-gbp org instead? The advantage there is that your package will automatically be available in the next ROS 2 distribution on release day.
https://docs.ros.org/en/rolling/How-To-Guides/Releasing/First-Time-Release.html#create-a-new-release-repository

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, it is more than an advantage; for rolling, we require that the release repository be in the ros2-gbp organization.

@@ -2699,6 +2699,17 @@ repositories:
url: https://github.com/iRobotEducation/irobot_create_msgs.git
version: rolling
status: developed
jacro:
release:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to include a doc tag so that documentation is automatically generated for your package? The documentation will be accessible from your package page on index.ros.org.

Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The release repository needs to be in the ros2-gbp organization for this to move forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes requested Maintainers have asked for changes to the pull request rolling Issue/PR is for the ROS 2 Rolling distribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants