-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jacro: 0.2.0-1 in 'rolling/distribution.yaml' [bloom] #43494
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New package review checklist
- At least one of the following must be present
- Top level license file:
- Per package license files:
- License is OSI-approved: BSD-3-Clause
- License correctly listed in package.xmls
- Public source repo: https://github.com/JafarAbdi/jacro.git
- Source repository contains ROS packages
- Each package meets REP-144 naming conventions
Left some comments to consider and will wait for secondary approval from @sloretz before we merge this.
release: | ||
tags: | ||
release: release/rolling/{package}/{version} | ||
url: https://github.com/JafarAbdi/jacro-release.git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to consider housing the release repo in the ros2-gbp org instead? The advantage there is that your package will automatically be available in the next ROS 2 distribution on release day.
https://docs.ros.org/en/rolling/How-To-Guides/Releasing/First-Time-Release.html#create-a-new-release-repository
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, it is more than an advantage; for rolling
, we require that the release repository be in the ros2-gbp
organization.
@@ -2699,6 +2699,17 @@ repositories: | |||
url: https://github.com/iRobotEducation/irobot_create_msgs.git | |||
version: rolling | |||
status: developed | |||
jacro: | |||
release: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to include a doc
tag so that documentation is automatically generated for your package? The documentation will be accessible from your package page on index.ros.org.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The release repository needs to be in the ros2-gbp organization for this to move forward.
Increasing version of package(s) in repository
jacro
to0.2.0-1
:rolling/distribution.yaml
0.12.0
null
jacro